Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add variables to forecast_generic #474

Merged
merged 2 commits into from
Mar 4, 2024
Merged

add variables to forecast_generic #474

merged 2 commits into from
Mar 4, 2024

Conversation

peterdudfield
Copy link
Contributor

Pull Request

Description

  • add variables to forecast_generic for pvnet. Add NWP_UKV_ZARR_PATH and NWP_ECMWF_ZARR_PATH

This is needed with openclimatefix/uk-pvnet-app#48

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce.
Please also list any relevant details for your test configuration

  • Yes

Checklist:

  • My code follows OCF's coding style guidelines
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked my code and corrected any misspellings

@peterdudfield peterdudfield marked this pull request as ready for review March 4, 2024 10:47
@peterdudfield peterdudfield merged commit a5f64ed into main Mar 4, 2024
4 checks passed
@peterdudfield peterdudfield deleted the pvnet-ecmwf branch March 4, 2024 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@peterdudfield